'stg edit' aborts on empty patch description; add instructions. #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topher200
force-pushed
the
stg-edit-aborts-on-empty-patch-description-add
branch
from
421d296 to
976fc10
Compare
This resolves stacked-git#138 by... 1. Adding instruction hints on the *power* of 'stg edit'. 2. Stripping these new hint lines from the description. 3. Aborting 'stg edit' if all description lines are cleared. From conversation on stacked-git#138 it became clear that aborting the 'edit' on an empty editor is correct. This behavior mirrors 'git commit' and 'stg squash'. Previously, if a user cleared the 'stg edit' editor window, the patch description would be cleared. This is unintuative! Users likely expect that this would abort the edit instead.
topher200
force-pushed
the
stg-edit-aborts-on-empty-patch-description-add
branch
from
976fc10 to
ad0d8d3
Compare
Collaborator
|
Thanks for this PR. Nice refinements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #138 by...
From conversation on #138 it became
clear that aborting the 'edit' on an empty editor is correct. This behavior
mirrors 'git commit' and 'stg squash'.
Previously, if a user cleared the 'stg edit' editor window, the patch
description would be cleared. This is unintuative! Users likely expect that
this would abort the edit instead.